Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: Rework the Melon Preferences system #838

Open
slxdy opened this issue Jan 22, 2025 · 0 comments
Open

[Enhancement]: Rework the Melon Preferences system #838

slxdy opened this issue Jan 22, 2025 · 0 comments
Labels
Improvement New feature or request Work-in-Progress This issue or pull request is being worked on currently

Comments

@slxdy
Copy link
Contributor

slxdy commented Jan 22, 2025

Describe the new feature or enhancement

Currently, all mod configs are stored in a single file. This can make it difficult to identify which section belongs to which mod. Next to that, mods can create multiple sections, which can lead to confusion.

My suggestion is to give each mod its own config file. Not only would this make it clearer for the user and the installer or third-party mod managers, but it would also allow for common mod settings.

Each mod config would contain common properties, such as disable or disable-logs, which would allow the user to change behavior of mods without moving files or writing any code.

To make it even easier for mod developers, we could implement Tomlet's serializer and deserializer, which would allow for creating properties through reflection, without the need to manually create each category and property through the MelonPrefs API.

Fixes #369

@HerpDerpinstine HerpDerpinstine added Improvement New feature or request Planned This issue is planned to be worked on Work-in-Progress This issue or pull request is being worked on currently and removed Planned This issue is planned to be worked on labels Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement New feature or request Work-in-Progress This issue or pull request is being worked on currently
Projects
None yet
Development

No branches or pull requests

2 participants