Always copy code and output when changing new language #15
Conversation
|
I also thought about that option. But this will require we have somewhere to store whether the code is dirty or not. In which we are only passing in a config dictionary to create the dialog. I'm not sure where can could store this information? And since I think this approach is also valid, I chose the easier approach. |
narrator0
force-pushed
the
fix/change-language-after-input-code
branch
from
d8761f0 to
34d3163
Compare
|
@celine168 I think we can merge this. The sample code is not necessary since the author is going to delete it and remove it anyway. I think keep the code is the best solution. |
|
I looked at the implementation myself. I think we should still keep the sample code since we made the starting language dynamic in #24. As there are a lot of commits to master after this PR that make this branch now have conflicts with master. I suggest rewrite the code and reopen another PR. |
This attempts to resolve #11. I change to plugin to always copy the previous code and output to the new Thebelab instance. I think the sample code is not important at all. We should move whatever code and output to the new instance. @celine168 let me know what you think.