Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generics in nested functions don't work for some annotations unless there are no arguments passed #3001

Open
Numynum opened this issue Dec 21, 2024 · 0 comments

Comments

@Numynum
Copy link

Numynum commented Dec 21, 2024

How are you using the lua-language-server?

Visual Studio Code Extension (sumneko.lua)

Which OS are you using?

Windows

What is the issue affecting?

Annotations

Expected Behaviour

passing an argument should have no effect, and the types of nested functions should be resolved correctly
some examples:

---@generic T
---@param arg T
---@return fun(): fun(): T
local function POOL1(arg) return function() return function() return arg end end end -- implementing the function makes no difference for the typing
local func1 = POOL1(5.2) -- type is `fun(): fun(): number`
local func2 = func1(4) -- type should be `fun(): number`, instead it's `fun(): <T>` with an unresolved generic
---@class POOL2<T>: { EnumerateActive: fun():(T, fun():T)) }
---@type POOL2<number>
local headerPool = {}
local number, func = headerPool:EnumerateActive()
-- number type is `number`
-- func type should be `fun(): number`, instead it's `fun(): <T>` with an unresolved generic
---@alias POOL3<T> fun(arg: number): T, (fun():T)
---@type POOL3<number>
local getPool
local number, func = getPool(3)
-- number type is `number`
-- func type should be `fun(): number`, instead it's `fun(): <T>` with an unresolved generic

all 3 examples work fine if you don't pass any argument

Actual Behaviour

when an argument is passed to the outer function, the inner function doesn't have the generic resolved
image
if no arguments are passed (i.e. headerPool.EnumerateActive()), then they are resolved properly
the type of the argument makes no difference, and annotating the function as accepting an argument also makes no difference

interestingly, when hovering over the function itself, the tooltip does show the correctly resolved types
image

Reproduction steps

copy the provided snippets, and check which types the variables resolve to

Additional Notes

Tested on both VSCode and Jetbrains IDEs
The example is contrived, my real usecase is to annotate an object pool class, that allows you to acquire objects of a given (generic) type, and allows iterating over them.

I know this has worked in a past version, though I don't remember how long ago that was (several weeks or months most likely)

Log File

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant