Latest VS 2019 update causes VS to hang and results in OOM

[mackie89]

Hey

The latest update from 01/24/25 seem to cause my VS2019 to hang on loading the project, and seems to result in an out of memory exception.

<entry>
    <record>8369</record>
    <time>2025/01/24 20:06:50.658</time>
    <type>Error</type>
    <source>VisualStudio</source>
    <description>SetSite failed for package [CmdArgsPackage]Source: &apos;System&apos; Description: 
	Exception of type &apos;System.OutOfMemoryException&apos; was thrown.&#x000D;&#x000A;System.OutOfMemoryException: 
	Exception of type &apos;System.OutOfMemoryException&apos; was thrown.&#x000D;&#x000A;   
	at System.Dynamic.ComRuntimeHelpers.CheckThrowException(Int32 hresult, ExcepInfo&amp; excepInfo, UInt32 argErr, String message)&#x000D;&#x000A;   
	at CallSite.Target(Closure , CallSite , ComObject )&#x000D;&#x000A;   
	at CallSite.Target(Closure , CallSite , Object )&#x000D;&#x000A;   
	at SmartCmdArgs.Services.ProjectConfigService.GetItemsFromVCProjEngineConfig(Project project, List`1 allArgs, Boolean includeArgs, Boolean includeEnvVars, Boolean includeWorkDir, Boolean includeLaunchApp)&#x000D;&#x000A;   
	at SmartCmdArgs.Services.ProjectConfigService.GetItemsFromProjectConfig(IVsHierarchyWrapper project)&#x000D;&#x000A;   
	at SmartCmdArgs.Services.ViewModelUpdateService.UpdateCommandsForProject(IVsHierarchyWrapper project)&#x000D;&#x000A;   
	at SmartCmdArgs.Services.LifeCycleService.InitializeDataForSolution()&#x000D;&#x000A;   
	at SmartCmdArgs.Services.LifeCycleService.IsEnabledChanged()&#x000D;&#x000A;   
	at SmartCmdArgs.Services.LifeCycleService.set_IsEnabledSaved(Nullable`1 value)&#x000D;&#x000A;   
	at SmartCmdArgs.Services.LifeCycleService.InitializeConfigForSolution()&#x000D;&#x000A;   
	at SmartCmdArgs.CmdArgsPackage.&lt;InitializeAsync&gt;d__23.MoveNext()&#x000D;&#x000A;
	--- End of stack trace from previous location where exception was thrown ---&#x000D;&#x000A;   
	at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)&#x000D;&#x000A;   
	at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)&#x000D;&#x000A;   
	at Microsoft.VisualStudio.Shell.AsyncPackage.&lt;&gt;c__DisplayClass20_0.&lt;&lt;Microsoft-VisualStudio-Shell-Interop-IAsyncLoadablePackageInitialize-Initialize&gt;b__1&gt;d.MoveNext()&#x000D;&#x000A;
	--- End of stack trace from previous location where exception was thrown ---&#x000D;&#x000A;   
	at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)&#x000D;&#x000A;   
	at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)&#x000D;&#x000A;   
	at Microsoft.VisualStudio.Shell.UIThreadReentrancyScope.WaitOnTaskCompleteInternal(Task task, CancellationToken cancel, Int32 ms)&#x000D;&#x000A;   
	at Microsoft.VisualStudio.Services.VsTask.&lt;&gt;c__DisplayClass100_1.&lt;InternalGetResult&gt;b__1()&#x000D;&#x000A;   
	at Microsoft.VisualStudio.Services.VsTask.IgnoreObjectDisposedException(Action action)&#x000D;&#x000A;   
	at Microsoft.VisualStudio.Services.VsTask.&lt;&gt;c__DisplayClass100_0.&lt;InternalGetResult&gt;b__0()&#x000D;&#x000A;   
	at Microsoft.VisualStudio.Services.VsTask.&lt;&gt;c__DisplayClass108_0.&lt;InvokeWithWaitDialog&gt;b__0()&#x000D;&#x000A;   
	at Microsoft.VisualStudio.Services.VsTask.InvokeWithWaitDialog[T](Func`1 function)&#x000D;&#x000A;   
	at Microsoft.VisualStudio.Services.VsTask.InvokeWithWaitDialog(Action action)&#x000D;&#x000A;   
	at Microsoft.VisualStudio.Services.VsTask.InternalGetResult(Boolean ignoreUIThreadCheck)&#x000D;&#x000A;   
	at Microsoft.VisualStudio.Services.VsTask.GetResult()</description>
    <guid>{131B0C0A-5DD0-4680-B261-86AB5387B86E}</guid>
    <hr>8007000e - E_OUTOFMEMORY</hr>
    <errorinfo></errorinfo>
  </entry>

[mackie89]

Hmmm that's weird even rolling back to a previous version doesn't seem to stop the hang. I even wiped my vcxproj.user file that contained my cmd args, it still hangs. This is a Unreal Engine project, I wonder if there has been something else that change that isn't playing well with this extension now.

[skyleryork]

Same issue here for multiple developers, using VS2022 on non-UE projects/solutions. There's ~5 minute hang on launch and devenv.exe uses ~15GB of RAM before becoming responsive again. Delay seems to vary depending on the size/complexity of the solution.

[Irame]

Hi, sorry for the late response, I will investigate the issue.

The code path in the call stack should only be executed if the project does not have any data available (.suo or .json file) for the extension. The extension then tries to gather all the used arguments from the VS configuration. But this is done on a per project basis and if you opened the solution before there should be a configuration for each project for the extension to look at.
Are there any other log entries that come from the extension that you can share with me?

This does not explain the Issue but I am wondering if @skyleryork does trigger the same code path. Do you have any log files (or log entries) for me to look at? Could you also give me the kind of solution you have (C++, C#, ...).

[amuTBKT]

I am facing a similar issue with my UE5 project (both at work and home).
Visual Studio: 17.11.5
Windows 10 Build 19045.5371
SmartCommandLineargs v3.2.0

I don't remember updating my Visual Studio, the issue just seem to happen overnight (one day was working fine next day started taking 5mins to load the project)
I think the only thing that changed for me was probably windows update, not sure how that could break the plugin ^^'

Issue:
From what I can tell we only save the *.args.json file for a project upon modification. Unreal project usually has the game project as startup while the main UE5 engine project is usually just added to the solution (not active by default). So the UE5.args.json file is never saved.
As a result every time the solution is opened, it takes a very long time to process UE5 project inside GetItemsFromVCProjEngineConfig function.

Workaround:

• Manually create UE5.args.json under $(ProjectDir) directory.
• Set UE5 to startup, add a dummy arg and ensure the file is created.

[Irame]

Thanks for the detailed comment.

The issue comes from accessing the config of each C++ project to collect the command line args. This is done because there aren't any ".args.json" files for these projects and therefore they are "new" to the extension. To avoid ignoring already set arguments we scan those projects and add the arguments to the extension.
For other projects types the cost of accessing the config isn't that high so it usually does not matter. As I fixed the collection of command line arguments for C++ projects with the last release the issue arose.

I am a bit confused as in how creating a .args.json file for a single project solves the issue as the extension should still scan the rest of the solution.

I implemented a solution for you to test. It basically asks you if you want to ignore C++ projects from the command args collection process when it finds more than 15 C++ projects.

SmartCmdArgs-vs2017-v3.2.0.1.vsix.zip
SmartCmdArgs-vs2019-v3.2.0.1.vsix.zip
SmartCmdArgs-vs2022-v3.2.0.1.vsix.zip
(I had to zip them, because GitHub does not allow .vsix files)

It would be nice if you could test the solution and share you feedback, thanks!

[skyleryork]

Hi, sorry for the late response, I will investigate the issue.

The code path in the call stack should only be executed if the project does not have any data available (.suo or .json file) for the extension. The extension then tries to gather all the used arguments from the VS configuration. But this is done on a per project basis and if you opened the solution before there should be a configuration for each project for the extension to look at. Are there any other log entries that come from the extension that you can share with me?

This does not explain the Issue but I am wondering if @skyleryork does trigger the same code path. Do you have any log files (or log entries) for me to look at? Could you also give me the kind of solution you have (C++, C#, ...).

I'm not sure about the callstack, but this is a solution with hundreds of C++ projects, so it makes sense that scanning would be the bottleneck. But only a single project builds an executable target, and it already has an .args.json that I've been using for a long time. Is it supposed to scan library projects, and/or generate argument files once it does? As far as I can tell, it doesn't create any new files so there's nothing to stop it from repeating the scan every time.