Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

503 fix mission v2 back / front #507

Closed
wants to merge 4 commits into from
Closed

503 fix mission v2 back / front #507

wants to merge 4 commits into from

Conversation

xtiannyeto
Copy link
Collaborator

No description provided.

aleckvincent and others added 3 commits January 16, 2025 15:57
@aleckvincent
fix issue with ui on create mission
1857616
@xtiannyeto
fix(action): refactor action to have a use_case getAction
730e2e4 
 - changing cache entry for getEnv
 - create getAction use case getting all action fish/nav/env
@xtiannyeto
fix(mission): Create a Mission object base on MissionAction
8df6d3a 
 - Create a new mission object
 - Create a new getMission
 - Create a new MissionEntity
 - Create a new FakeMission to Match the new mission model
 - Update controller to use new GetMission
@xtiannyeto xtiannyeto linked an issue Jan 20, 2025 that may be closed by this pull request
fix modal creation design #503
Open
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 20, 2025 •
edited
Loading

Coverage Report for frontend

Status Category Percentage Covered / Total
🟢 Lines 58.81% (🎯 40%) 2538 / 4315
🟢 Statements 57.87% (🎯 40%) 2641 / 4563
🟢 Functions 44.25% (🎯 40%) 612 / 1383
🟢 Branches 48.9% (🎯 40%) 1029 / 2104
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
frontend/src/v2/features/ulam/components/element/mission-create-dialog.tsx 100% 100% 100% 100%
frontend/src/v2/features/ulam/components/element/mission-general-information-initial-form.tsx 83.33% 66.66% 66.66% 83.33% 87
Generated in workflow #1585 for commit a335ff7 by the Vitest Coverage Report Action

@xtiannyeto
fix(test): Controlller test fix
a335ff7 
 - add mock on getMission2
@github-actions GitHub Actions
Copy link

Overall Project 50.17% -1.36% ❌
Files changed 41.21% ❌

File Coverage
CaffeineConfiguration.kt 100% 🍏
AbstractGetMissionAction.kt 89.13% -10.87% 🍏
MissionEnvData.kt 88.48% -10.41% 🍏
GetEnvActionById.kt 83.85% 🍏
MissionRestController.kt 83.17% -4.81% 🍏
GetNavActionById.kt 82.86% 🍏
MissionGeneralInfo2.kt 79.43% -20.57% ❌
GetFishActionById.kt 78.53% 🍏
GetNavActionListByMissionId.kt 77.78% 🍏
GetEnvActionListByMissionId.kt 77.42% 🍏
GetFishActionListByMissionId.kt 76.98% 🍏
Mission2.kt 69.38% -28.75% ❌
GetEnvMissionById2.kt 57.14% -6.12% ❌
MissionEntity2.kt 54.15% -45.85% ❌
GetMission2.kt 0% -81.25% ❌
GetGeneralInfo2.kt 0% -91.26% ❌
GetMissionAction.kt 0% -82% ❌
MissionActionRestController.kt 0% -4.95% ❌
FakeMissionData2.kt 0% -99.42% ❌
MissionGeneralInfoEntity2.kt 0% ❌

@xtiannyeto xtiannyeto changed the title 503 fix modal creation design 503 fix mission v2 back / front Jan 20, 2025
@xtiannyeto xtiannyeto closed this Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix modal creation design
2 participants
@xtiannyeto @aleckvincent