Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI Improvements in Script Validation for Items that use UNCHANGED #307

Open
terrypacker opened this issue Nov 21, 2019 · 2 comments
Open

Comments

@terrypacker
Copy link
Contributor

terrypacker commented Nov 21, 2019

Some scripts can return the special value of UNCHANGED to indicate not to do something.

  • The Email Handler will not send the email
  • A Meta Point will not update it's value

The way to correctly validate these is to ensure the resultDataType is set to BOOLEAN in the MangoJavaScriptModel when validating Email Handlers and Point Links otherwise no result will be returned as none is expected.

The result will be an Alphanumeric point value that contains the translated words for the translation eventHandlers.script.successUnchanged. See the attached for how a Meta Point displays this result:

image

@terrypacker
Copy link
Contributor Author

terrypacker commented Apr 8, 2020

Left TODO:

  • Set Point Handler Script should be validated using this endpoint: /event-handlers/validate-set-point-handler-script
  • Excel Reports

The data type is set on the backend to ensure the result will be returned. The UI should not display an empty script result though, which will happen if there is no return statement on the script.

@pierpuccini pierpuccini removed their assignment Apr 8, 2020
@terrypacker
Copy link
Contributor Author

We need to handle the situation where no value is returned during validation but the validate tool still display an empty result.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants