Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't sort ProjectChecker messages by line number #1121

Open
Brownies opened this issue Oct 13, 2024 · 1 comment
Open

Don't sort ProjectChecker messages by line number #1121

Brownies opened this issue Oct 13, 2024 · 1 comment

Comments

@Brownies
Copy link

ProjectChecker messages are sorted here and because of the comparison function for messages they get sorted by line number, column and then rule id.

I don't think this makes sense specifically for rules that operate on the whole project. I would prefer the checker output didn't get sorted at all in run_project_checks() and so the order would be up to the checker. But sorting by source path first would also be an improvement.

@bhirsz
Copy link
Member

bhirsz commented Oct 13, 2024

Good point. At this point I would even consider current behaviour as a bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants