Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated function mbedtls_x509write_crt_set_serial() #9892

Open
mpg opened this issue Jan 10, 2025 · 0 comments
Open

Remove deprecated function mbedtls_x509write_crt_set_serial() #9892

mpg opened this issue Jan 10, 2025 · 0 comments
Labels
api-break This issue/PR breaks the API and must wait for a new major version component-x509 size-s Estimated task size: small (~2d)

Comments

@mpg
Copy link
Contributor

mpg commented Jan 10, 2025

The function mbedtls_x509write_crt_set_serial() has been deprecated in favour of mbedtls_x509write_crt_set_serial_raw(). On reason it's problematic is because it has an argument of type mbedtls_mpi from bignum.h which is going to be private in 1.0/4.0.

This task is to:

  • Remove this function (declaration and definition).
  • Remove tests that are specifically about it. (Test that are not specifically about it should have already been migrate to mbedtls_x509write_crt_set_serial_raw() but still double-check.)
  • Remove mentions in the documentation. At this point git grep -w mbedtls_x509write_crt_set_serial should only find matches in the ChangeLog.
  • Add a ChangeLog entry about the removal.

This task is development-only.

@mpg mpg added component-x509 api-break This issue/PR breaks the API and must wait for a new major version size-s Estimated task size: small (~2d) labels Jan 10, 2025
@mpg mpg moved this to Implementation needed in Mbed TLS 4.0 planning Jan 10, 2025
@mpg mpg moved this to Remove legacy types from public non-PSA interfaces in Mbed TLS Epics Jan 10, 2025
@mpg mpg mentioned this issue Jan 10, 2025
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api-break This issue/PR breaks the API and must wait for a new major version component-x509 size-s Estimated task size: small (~2d)
Projects
Status: Implementation needed
Status: Remove legacy types from public non-PSA interfaces
Development

No branches or pull requests

1 participant