Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

341-Update Details Viewer UI #348

Merged
merged 12 commits into from
Dec 6, 2023
Merged

341-Update Details Viewer UI #348

merged 12 commits into from
Dec 6, 2023

Conversation

Aiga115
Copy link
Contributor

@Aiga115 Aiga115 commented Dec 5, 2023

Issue #341
Problem: Update Details Viewer UI

  1. Add color icon
  2. Fix selected icon on search - https://github.com/MetaCell/salk-interactive-atlas/assets/19196034/72a013f3-852e-433c-8310-e67558641509
  3. Have the pagination buttons visible without the need to scroll (if possible)
  4. Only show delete if the user has permission
  5. tab title change -> tab title change #336

Solution:
image

  1. Solved by passing color and opacity prop to icon color generator
  2. Solved by adding an additional check, so if there is no seach value it doesn't show tick icon
  3. Solved by adding additional styles, that fixes the parent component to be always at the bottom
  4. Solved by receiving editPermission prop
  5. Solved by iterating through map and adding a check when we encounter specific tab and changing it to the specified text

@Aiga115 Aiga115 requested a review from afonsobspinto December 5, 2023 16:44
Copy link
Member

@afonsobspinto afonsobspinto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking much better.

There's just a small problem with the search, where the immediate search after doesn't include all the options:

2023-12-06.13-53-38.mp4

@afonsobspinto afonsobspinto merged commit 759713e into develop Dec 6, 2023
3 checks passed
This was linked to issues Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Details Viewer UI tab title change
2 participants