Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Share experiment feature during creation #371

Open
neuroBazzi opened this issue Jan 19, 2024 · 5 comments
Open

Share experiment feature during creation #371

neuroBazzi opened this issue Jan 19, 2024 · 5 comments
Assignees
Labels
enhancement New feature or request SOW6

Comments

@neuroBazzi
Copy link

neuroBazzi commented Jan 19, 2024

From the client:

Share feature appears to be disabled. This is an open issue that Afonso just started addressing at the end of the last SOW, according to github. He wants to make it an option during upload for a dataset/cord to be public.

@afonsobspinto could you please weigh in wrt to what's missing? cc @zsinnema @D-GopalKrishna

@neuroBazzi neuroBazzi added enhancement New feature or request SOW6 labels Jan 19, 2024
@neuroBazzi neuroBazzi changed the title Sahre feature Share experiment feature during creation Jan 19, 2024
@afonsobspinto
Copy link
Member

Experiments are private by default (they are only available for the user who created them). Right now, we have no way to change this through application UI.
In the admin page we can:

  • Make the experiment public (it will become visible for any user)
  • Give permission to a team and consequently all its elements to edit the experiment.
  • Give permission to a specific collaborator (viewer / editor)

In order to have the above available in the application we need to:

  1. Create the frontend modal component (16h)
  2. Add SMTP server to handle the email invitation (8h)
  3. Implement backend endpoints
    a) Test and fix permissions/roles (8h) (@zsinnema did all the modelling for these features and I believe most of it is functional but I would feel more comfortable with this buffer for any problems we might find out during the integration)
    b) Add invite endpoint (2h)
  4. Connect the frontend to the backend (8h)

I don't know how the multiple experiments dialog is shown, maybe we don't need it? The above estimation doesn't include it.
cc @neuroBazzi

@neuroBazzi
Copy link
Author

thanks @afonsobspinto, I am not sure what you mean by 'multiple experiments dialog' can you please elaborate on that? Also, users are going to be able to share only during creation or will they be able to share the experiment after it has bee created (and inspected)?
I can see a workflow where the user shares the experiment after they create it (Ad inspect it) rather than during the creation process itself. would this make things simpler? like adding the share functionality in the drop down fo the figure below. @syamace-metacell thoughts?

Screenshot 2024-01-22 at 09 08 43

@afonsobspinto
Copy link
Member

afonsobspinto commented Jan 22, 2024

Sharing multiple experiments was one of the components I saw in the figma design. Meanwhile, thanks to your suggestion above I found out where it was triggered. Here are the flows I found in figma:

(Context menu trigger)
image
(Share modal)
image
(Share multiple modal - Do we need it?)
image
(Share button in the experiment page)
image

What I can't find is a way to define who to share it with at creation time (As you said, we can make the case that we don't need it, and the user can only share after creation)

@neuroBazzi
Copy link
Author

Thanks Afonso, I frankly forgot about the sharing multiple. I would leave it on the side for now as it is not a pressing use case. I would default that the user wants to share an exp after the creation (From the menu as showed in the picture) and experiments can only share with an existing user (i.e. you cannot input an email address of someone who is not in the Keycloak db, you can only input unsernames or email from keycloack). does this make sense? cc @syamace-metacell

@neuroBazzi
Copy link
Author

uh, also, let's keep in mind users might want to un-share an experiment. so she Share line might open a model where we see with whom the experiment has been shared, and the user can 'remove' someone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request SOW6
Projects
None yet
Development

No branches or pull requests

2 participants