Create simulation component for permits #12432
Assignees
Labels
INVALID-ISSUE-TEMPLATE
Issue's body doesn't match any issue template.
release-7.39.0
Issue or pull request that will be included in release 7.39.0
Comments
metamaskbot
added
the
INVALID-ISSUE-TEMPLATE
github-merge-queue bot
pushed a commit
that referenced
this issue
Jan 15, 2025
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** Creates Permit Simulation UI to be shown on V3 and V4 signTypedData confirmations. Signature Decoding logic to be added following this PR. ### Add - create ButtonPill component - create PermitSimulation component - add to TypedSignV3V4 component - create constants/signatures.ts file - create hooks/useGetTokenStandardAndDetails files - create hooks/useTrackERC20WithoutDecimalInformation.ts file - create utils/signature.ts file - create utils/token.ts file ### Update - add style param to UI/Name component - add noBorder param to Box component - add TokenStandard enum - add handleCloseOnBackdropClick param to confirmation BottomModal component - add skipCharacterInEnd param to shortenString common util. This mimics the same logic in extension ### Designs Simulations MVP https://www.figma.com/design/8DrinrQI4hs76Grm2F34xK/Simulations-MVP?node-id=1283-18713&node-type=canvas&t=FbRsIUjxMDxC3Get-0 Confirmations Redesign V5 https://www.figma.com/design/wcXUl6AH5KNFwKdAIv49kh/Confirmation-redesign-V5?node-id=4157-7776&node-type=canvas&m=dev ## **Related issues** Fixes: #12432 Related: #12994 (Signature Decoding Simulation - follow-up PR) ###: Follow-up - Related: #12910 (Create storybook page + unit tests for ButtonPill) - Related: #13013 (Do not use Ramp/Box. Use View instead) - Related: #13016 (Move shortenString helper location) ## **Manual testing steps** 1. Test Permit test-dapp button ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <img width="320" src="https://github.com/user-attachments/assets/a7a478b0-6b05-47a6-b68c-c691af82c5ee">  ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
metamaskbot
added
the
release-7.39.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
Implement Permit Simulation for Mobile Redesign confirmation. The logic will resemble th extension logic. This will include Security Decoder API
Designs
Simulations MVP https://www.figma.com/design/8DrinrQI4hs76Grm2F34xK/Simulations-MVP?node-id=1283-18713&node-type=canvas&t=FbRsIUjxMDxC3Get-0
Confirmations Redesign V5 https://www.figma.com/design/wcXUl6AH5KNFwKdAIv49kh/Confirmation-redesign-V5?node-id=4157-7776&node-type=canvas&m=dev
The text was updated successfully, but these errors were encountered: