Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: re-designs signatures, continue to use old designs when signing with hardware wallets #12976

Merged
merged 15 commits into from
Jan 15, 2025
Merged

fix: re-designs signatures, continue to use old designs when signing with hardware wallets #12976

merged 15 commits into from
Jan 15, 2025
+144 −2

Conversation

jpuri
Copy link
Contributor

@jpuri jpuri commented Jan 14, 2025 •
edited
Loading

Description

Render old designs if hardware wallet or WR aware device is used for signing.

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/3870

Manual testing steps

  1. Enable re-designs locally
  2. Try to sign signature request using hardware wallet
  3. It should work in old designs

Screenshots/Recordings

TODO

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions GitHub Actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-confirmations Push issues to confirmations team label Jan 14, 2025
@jpuri jpuri marked this pull request as ready for review January 15, 2025 09:05
@jpuri jpuri requested a review from a team as a code owner January 15, 2025 09:05
@jpuri jpuri changed the title Re-design signature changes for QR hardware support fix: re-designs signatures, continue to use old designs when signing with hardware wallets Jan 15, 2025
@jpuri jpuri added the Run Smoke E2E Triggers smoke e2e on Bitrise label Jan 15, 2025
@github-actions GitHub Actions
Copy link
Contributor

https://bitrise.io/ Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: 46aeb36
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/5bd6a054-3b73-452a-bb19-18e54bbaa669

Note

  • This comment will auto-update when build completes
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@jpuri jpuri added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jan 15, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 15, 2025 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: c7b4564
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/56c65ade-73a3-40c7-9013-3f7c13ee80d5

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@jpuri jpuri requested a review from OGPoyraz January 15, 2025 10:54
@jpuri jpuri enabled auto-merge January 15, 2025 12:44
OGPoyraz
OGPoyraz previously approved these changes Jan 15, 2025
View reviewed changes
@jpuri jpuri requested a review from matthewwalsh0 January 15, 2025 13:31
@jpuri jpuri requested a review from OGPoyraz January 15, 2025 13:31
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
92.9% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@jpuri jpuri added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jan 15, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 15, 2025 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 8fc3a8c
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/7883b3a9-09a6-4cc9-8bbb-3b1aca771d1a

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@jpuri jpuri added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jan 15, 2025
@jpuri jpuri added this pull request to the merge queue Jan 15, 2025
Merged via the queue into main with commit b047169 Jan 15, 2025
44 of 45 checks passed
@jpuri jpuri deleted the signing_hardware_wallets branch January 15, 2025 17:53
@github-actions github-actions bot locked and limited conversation to collaborators Jan 15, 2025
@metamaskbot metamaskbot added the release-7.39.0 Issue or pull request that will be included in release 7.39.0 label Jan 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@matthewwalsh0 matthewwalsh0 matthewwalsh0 approved these changes

@OGPoyraz OGPoyraz Awaiting requested review from OGPoyraz

Assignees
No one assigned
Labels
release-7.39.0 Issue or pull request that will be included in release 7.39.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-confirmations Push issues to confirmations team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jpuri @OGPoyraz @matthewwalsh0 @metamaskbot