Skip to content
This repository has been archived by the owner on Sep 3, 2018. It is now read-only.

Use build step to automatically inject text placeholders #21

Closed
MichaelKohler opened this issue Jul 3, 2018 · 2 comments
Closed

Use build step to automatically inject text placeholders #21

MichaelKohler opened this issue Jul 3, 2018 · 2 comments
Labels
enhancement New feature or request help-wanted Extra attention is needed
Milestone
v1.0 - final

Comments

@MichaelKohler
Copy link
Owner

Currently we have the following issue: we have to have placeholders in the JSX files to make sure we show the EN text if loading the localization file (or something along the way) fails. This means that any EN update needs to be in two places: 1) placeholder in JSX, 2) en-US.ftl file.

It would be great if we could delete all placeholder texts in the source and have a build step that automatically injects the translations as fallback. This could be rather tough though as this build step would need to understand FTL.

Happy to review PRs and/or answer questions around this if somebody wants to give this a shot :)
@MichaelKohler MichaelKohler added enhancement New feature or request help-wanted Extra attention is needed labels Jul 3, 2018
@MichaelKohler MichaelKohler added this to the v1.0 - final milestone Jul 13, 2018
@MichaelKohler
Copy link
Owner Author

Blocked by #34 for now

@MichaelKohler
Copy link
Owner Author

We're gonna leave this for now.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement New feature or request help-wanted Extra attention is needed
Projects
None yet
Milestone
v1.0 - final
Development

No branches or pull requests
1 participant
@MichaelKohler