Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error occurred while enabling spark-expansion #21

Open
EmanYm opened this issue Nov 24, 2023 · 13 comments
Open

Error occurred while enabling spark-expansion #21

EmanYm opened this issue Nov 24, 2023 · 13 comments

Comments

@EmanYm
Copy link

EmanYm commented Nov 24, 2023

It started to happen when I updated everything to 1.20.2. It appears to be cause by Spark plugin not even loading until thirteen lines later
https://pastebin.com/jR6qUDy8

Environment is Purpur version git-Purpur-2092 (MC: 1.20.2) (Implementing API version 1.20.2-R0.1-SNAPSHOT) (Git: 4b1a082 on HEAD)

@4drian3d
Copy link
Member

Could you provide a more complete log? It's practically impossible for that to happen unless Purpur has a bug with the Paper plugins again

@EmanYm
Copy link
Author

EmanYm commented Nov 24, 2023

latest.log
There were no other issues that I could see. I doubt the current issue i have with HeadDisplay would effect the MiniPlaceholder for Spark. But I've seen more obscure connections to errors.

@EmanYm
Copy link
Author

EmanYm commented Nov 27, 2023

I am still having this problem. It seems to be trying to load the spark expansion before Spark.

@4drian3d
Copy link
Member

image
Try using Paper

@EmanYm
Copy link
Author

EmanYm commented Dec 3, 2023

Shoot, I forgot about this.
Loading up my dev server with just Paper 1.20.2, Spark, MiniPlacceholders and MiniPlaceholdersExpansion-Spark

It loads without the reported error on Paper with no other plugins, but it does say it's loading in legacy loading logic mode.
paper-latest.log

To complete the test, I swapped back to Purpur with the same set of plugins.
Deleted the contents of /cache, /config, /jar, /libraries and /versions so that it will download fresh copies of everything.
purpur-latest.log
Again, it doesn't throw that error, but miniplaceholders does try to load in legacy mode.

@4drian3d
Copy link
Member

4drian3d commented Dec 3, 2023

It seems that it is a problem of your host that has activated the legacy plugin loading, I would recommend you to open a ticket in their support. But anyway, this should not affect MiniPlaceholders

@EmanYm
Copy link
Author

EmanYm commented Dec 3, 2023

I have requested several times that Legacy Loading be turned off. I don't know why it keeps getting turned back on.
I will go talk to them again.

Thank you for your time Adrian.

@EmanYm
Copy link
Author

EmanYm commented Dec 3, 2023

I had the legacy loading logic disabled for my dev server, and now it throws the error again
purpur lll-off latest.log

@4drian3d
Copy link
Member

4drian3d commented Dec 3, 2023

This must be a problem with Purpur as it comes with its own version of Spark installed, I would recommend you to go to their support. My plugins are guaranteed to work with Paper, if any fork makes any modification it's their problem. Although I know Paper is planning to integrate Spark in the future or make a new tracking tool

@EmanYm
Copy link
Author

EmanYm commented Dec 3, 2023

It usually ignores the built-in spark if the plugin version exists in the plugin folder.
I will figure it out. Again, thank you for your time. You can close this when you read it.

Edit:
I flipped back to Paper with Legacy Loading Logic disabled to do one last test, and it's still saying MiniPlaceholders and Spark Expansion are trying to load in Legacy mode.
paper - l3 disabled

@EmanYm
Copy link
Author

EmanYm commented Dec 3, 2023

Purpur suggests that MiniPlaceholdersExtension-Spark should have Spark as a dependancy.

@4drian3d
Copy link
Member

4drian3d commented Dec 3, 2023

https://github.com/MiniPlaceholders/Spark-Expansion/blob/main/paper/src/main/resources/paper-plugin.yml#L10
This expansion already has Spark as a dependency, otherwise it could not be loaded

@EmanYm
Copy link
Author

EmanYm commented Dec 4, 2023

After some more digging, I edited the paper-plugin.yml to include load lines
load: AFTER for MiniPlaceholders
load: AFTER for Spark
The expansion now loads after the Spark plugin without throwing an error

And I found out why I keep getting the legacy Loading Logic warnings. Every time I change my jar it resets custom flags set by the staff of my host

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants