From 89ef6ebc89c5041e00b05fad2c5829937ea950d7 Mon Sep 17 00:00:00 2001
From: Dan <dan@whitehat.org.uk>
Date: Mon, 15 Apr 2019 09:08:35 +0100
Subject: [PATCH] using config for helpers everywhere

---
 lib/sort_view.ex | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/lib/sort_view.ex b/lib/sort_view.ex
index 7d03295..95e5ed1 100644
--- a/lib/sort_view.ex
+++ b/lib/sort_view.ex
@@ -4,7 +4,7 @@ defmodule Sortex.SortView do
   def column_class, do: "sortex-clickable-column"
 
   def sorted_column(conn, opts) do
-    helper = opts[:helper]
+    helper_action = opts[:helper]
     action = opts[:action] || :index
     helpers_module = Application.get_env(:sortex, :route_helpers_module)
 
@@ -13,19 +13,19 @@ defmodule Sortex.SortView do
 
     url =
       case opts[:route_params] do
-        nil -> apply(helpers_module, helper, [conn, action, params])
-        route_params -> add_params(conn, helper, action, route_params, params)
+        nil -> apply(helpers_module, helper_action, [conn, action, params])
+        route_params -> add_params(helpers_module, conn, helper_action, action, route_params, params)
       end
 
     Phoenix.HTML.raw(~s(<a href="#{url}" class="#{column_class()}">#{title(opts, arrow)}</a>))
   end
 
-  defp add_params(conn, helper, action, route_params, params) when is_list(route_params) do
-    apply(Helpers, helper, [conn, action] ++ route_params ++ [params])
+  defp add_params(helpers_module, conn, helper_action, action, route_params, params) when is_list(route_params) do
+    apply(helpers_module, helper_action, [conn, action] ++ route_params ++ [params])
   end
 
-  defp add_params(conn, helper, action, route_params, params) do
-    apply(Helpers, helper, [conn, action, route_params, params])
+  defp add_params(helpers_module, conn, helper_action, action, route_params, params) do
+    apply(helpers_module, helper_action, [conn, action, route_params, params])
   end
 
   defp params(opts, query_params, direction) do