Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update authors in CMakeLists.txt #448

Closed
climbfuji opened this issue Apr 16, 2022 · 6 comments
Closed

Update authors in CMakeLists.txt #448

climbfuji opened this issue Apr 16, 2022 · 6 comments

Comments

@climbfuji
Copy link
Collaborator

Guess it's time to update authors in the top-level CMakeLists.txt (and potentially other CMakeLists.txt files in subdirectories).

set(AUTHORS "Dom Heinzeller" "Grant Firl" "Laurie Carson")

@climbfuji
Copy link
Collaborator Author

@dustinswales @gold2718 @peverwhee Should this list be the same as what's in CODEOWNERS, or a subset/superset of it?

@dustinswales
Copy link
Collaborator

I updated the authors in #504.
@gold2718 Do you want to still be on this list?

@gold2718
Copy link
Collaborator

gold2718 commented Dec 8, 2023

I updated the authors in #504. @gold2718 Do you want to still be on this list?

I guess it depends on the purpose of the variable but I would say yes.

  • It would be useful as a point of contact (but then, an email or GitHub ID would be a useful addition).
  • For "who to blame when something goes wrong", I still have plenty of fingerprints in the code.
  • For posterity, well, then, we should never remove any authors (e.g., https://earthsystemmodeling.org/docs/release/latest/ESMF_usrdoc/).

@climbfuji
Copy link
Collaborator Author

Based on the comments above, can we add Steve back in https://github.com/NCAR/ccpp-framework/pull/504/files --> CMakeLists.txt in exchange for a review and approval, so that we can move ahead (and close this issue as done)?

@dustinswales
Copy link
Collaborator

Addressed in #504

@gold2718
Copy link
Collaborator

I'm not sure what the final decision was but comparing the result with 'git blame', we have:
Steve Goldhaber: 23675 (2023)
Julie Schramm: 14792 (2021)
Dom Heinzeller: 12455 (2024)
Courtney Peverley: 4566 (2024)
Dustin Swales: 785 (2024)
Michael Kavulich, Jr: 357 (2024)
Laurie Carson: 2225 (2021)
Timothy Brown: 146 (2017)
Noah D. Brenowitz: 54 (2021)
Grant Firl: 66 (2024)
Ufuk Turuncoglu: 23 (2022)
Dusan Jovic: 22 (2024)
John Michalakes: 14 (2023)
Michael Waxmonsky: 6 (2023)
Cheryl Craig: 3 (2020)
Dave Gill: 1 (2017)
Man Zhang: 1 (2020)

where the number after the colon is the number of lines of code shown by git blame and the year of last contribution is shown in parentheses. Data as of commit 011db4f.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants