Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try to remove redundant code #215

Open
K20shores opened this issue Sep 4, 2024 · 0 comments
Open

Try to remove redundant code #215

K20shores opened this issue Sep 4, 2024 · 0 comments

Comments

@K20shores
Copy link
Collaborator

We have a little of if blocks that figure out which pointer we need to pass to functions.

https://github.com/NCAR/musica/blob/main/src/micm/micm.cpp#L207-L237

Can we instead push all of the decisions of which pointer to pass down to the micm class and remove these decisions from the C layer?

Ideas

  • Use std::variant for the pointer types
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@K20shores