-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests failing because of pathlib.PosixPath types in pickled objects #169
Comments
I wonder if changing them to pathlib.Path objects would do the trick as well. |
pathlib.Path does not seem to fix. |
Still sorting out details, but just documenting here that the tests fail starting with version 4 of deepdiff thus the fix w/ requiring v3.3.0. |
I assume i subclassed this to avoid waiting forever for this PR, as in the second part: Maybe that's what's breaking.... something changes WRT this subclass:
|
Fun with subclassing |
Yeah, I think the updates to DeepDiff for v4 now trigger an exception which results in "unprocessed" output before your new function in the subclass deals with the pathlib.PosixPath stuff. I started trying to edit the subclass (unless we want to ignore these, that seems like the way to go), but ran out of time for now. |
test_simulation_pickle and test_simulation_sub_obj_pickle are currently failing because deepdiff can't compare the pathlib.PosixPath types within these objects.
Adding exclude_types={pathlib.PosixPath} as an argument to DeepDiff will make the tests pass, but may circumvent intended testing.
The text was updated successfully, but these errors were encountered: