Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests failing because of pathlib.PosixPath types in pickled objects #169

Open
kafitzgerald opened this issue Apr 16, 2019 · 7 comments
Open

Comments

@kafitzgerald
Copy link
Contributor

test_simulation_pickle and test_simulation_sub_obj_pickle are currently failing because deepdiff can't compare the pathlib.PosixPath types within these objects.

Adding exclude_types={pathlib.PosixPath} as an argument to DeepDiff will make the tests pass, but may circumvent intended testing.

@jmccreight
Copy link
Collaborator

I wonder if changing them to pathlib.Path objects would do the trick as well.

@jmccreight
Copy link
Collaborator

pathlib.Path does not seem to fix.

@kafitzgerald
Copy link
Contributor Author

Still sorting out details, but just documenting here that the tests fail starting with version 4 of deepdiff thus the fix w/ requiring v3.3.0.

@jmccreight
Copy link
Collaborator

ha: seperman/deepdiff#103

@jmccreight
Copy link
Collaborator

I assume i subclassed this to avoid waiting forever for this PR, as in the second part:
seperman/deepdiff#104

Maybe that's what's breaking.... something changes WRT this subclass:

class DeepDiffEq(DeepDiff):

@jmccreight
Copy link
Collaborator

Fun with subclassing

@kafitzgerald
Copy link
Contributor Author

Yeah, I think the updates to DeepDiff for v4 now trigger an exception which results in "unprocessed" output before your new function in the subclass deals with the pathlib.PosixPath stuff. I started trying to edit the subclass (unless we want to ignore these, that seems like the way to go), but ran out of time for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants