Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LAMA to Dask: reinstate string-like data equality test #298

Open
sadielbartholomew opened this issue Jan 21, 2022 · 0 comments
Open

LAMA to Dask: reinstate string-like data equality test #298

sadielbartholomew opened this issue Jan 21, 2022 · 0 comments
Labels
dask Relating to the use of Dask

Comments

@sadielbartholomew
Copy link
Member

(For the lama-to-dask branch RE the overarching #182 task,) once NCAS-CMS/cfdm#172 is resolved, the following assertion can be reinstated in the test_Data_equals test:

# Unlike for numeric types, for string-like data as long as the data
# is the same consider the arrays equal, even if the dtype differs.
# TODO DASK: this behaviour will be added via cfdm, test fails for now
# ## self.assertTrue(sa1.equals(sa2))

Presently it is commented out as shown because it is failing on lack of appropriate behaviour in cfdm.

@sadielbartholomew sadielbartholomew added the dask Relating to the use of Dask label Jan 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dask Relating to the use of Dask
Projects
None yet
Development

No branches or pull requests

1 participant