Skip to content
This repository has been archived by the owner on Feb 12, 2020. It is now read-only.

[Refactor] Fix error handling #25

Open
freddy5566 opened this issue Aug 23, 2019 · 11 comments
Open

[Refactor] Fix error handling #25

freddy5566 opened this issue Aug 23, 2019 · 11 comments
Assignees
Labels
refactor Refactor the code

Comments

@freddy5566
Copy link
Member

Summary

currently error handling is such a mess, it gotta be improved

@freddy5566 freddy5566 added the refactor Refactor the code label Aug 23, 2019
@thelebdev
Copy link

I could take that on

@freddy5566
Copy link
Member Author

Hi @christopheelkhoury,

do you have any though about your plan to improve error handling

@thelebdev
Copy link

It all depends on the business requirements.
1- Figure out which errors to return to the users via HTTP Response
1.1- Error Codes (HTTP Status Code)
1.2- Error Message (HTTP Response Body)
2- Figure out which errors ought to be breaking (e.g. if you're updating childModel1, childModel2 and parentModel, in the case where childModel1 failed to update, do you break the whole operation or do you continue off?)
3- Figure out how and where to log your errors (e.g. using packages, building your own like I have, etc.)

@freddy5566
Copy link
Member Author

freddy5566 commented Aug 23, 2019

It's really thanks for your contribution, do you mind to add some sort of logging for debugging, if you are interesting in this one, then fluentd will be cool.
But I believe it will be the next couple PR.

@freddy5566
Copy link
Member Author

I've add you as Assignees feel free to open PR. Thanks again.

@thelebdev
Copy link

I'll look into it after working hours. Do you guys have discord/slack/telegram for this project's contributors?

@freddy5566
Copy link
Member Author

Could you give us your e-mail? We add you into our slack channel

@thelebdev
Copy link

[email protected]

@thelebdev
Copy link

I think @DennySORA 's Pull Request does a bit of error handling. It would be a good idea to use that same pull request, or branch out of it, and continue on.

@freddy5566
Copy link
Member Author

@thelebdev Let's keep it simple just pitch on that PR.

@thelebdev
Copy link

@jamfly keep in mind though. Error handling is related to business requirement.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
refactor Refactor the code
Projects
None yet
Development

No branches or pull requests

2 participants