Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

omf should be Obs_Minus_Forecast_unadjusted #39

Open
HaixiaLiu-NOAA opened this issue Feb 26, 2021 · 2 comments
Open

omf should be Obs_Minus_Forecast_unadjusted #39

HaixiaLiu-NOAA opened this issue Feb 26, 2021 · 2 comments

Comments

@HaixiaLiu-NOAA
Copy link

The omf plot currently is plotting the Obs_Minus_Forecast_adjusted which means omf after bias correction, which confuses user. I think the omf should be Obs_Minus_Forecast_unadjusted (omf before bias correction).

@HaixiaLiu-NOAA
Copy link
Author

just one line of change in pyGSI/diags.py

change the following line
self.omf = f.variables['Obs_Minus_Forecast_adjusted'][:]

to
self.omf = f.variables['Obs_Minus_Forecast_unadjusted'][:]

@HaixiaLiu-NOAA
Copy link
Author

it is better to add more variable plotting options to include both omfbc (adjusted=after bias correction) and omfnbc (unadjusted=before bias correction)).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant