Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve PyGSI on conventional data #59

Open
XiujuanSu-NOAA opened this issue Sep 2, 2021 · 6 comments
Open

Improve PyGSI on conventional data #59

XiujuanSu-NOAA opened this issue Sep 2, 2021 · 6 comments

Comments

@XiujuanSu-NOAA
Copy link
Contributor

To add some changes on current PyGSI package.

@CoryMartin-NOAA
Copy link
Contributor

@XiujuanSu-NOAA can you rename the issue and add some specifics on what exactly you are adding/improving?

@XiujuanSu-NOAA XiujuanSu-NOAA changed the title Improve PyGSI package Improve PyGSI on conventional data Sep 2, 2021
@XiujuanSu-NOAA
Copy link
Contributor Author

Added more data items on function: _read_obs such as setupqc, vqc, and all error items.
Added one data category: rejected to the functions: get_data, _get_idx_conv, get_lat_lon, get_pressure,get_height for conventional data. The reason to have this change is that there are differences between observations rejected in GSI and monitored. It is useful to know rejected data counts and their O-A and O-B characters.

@XiujuanSu-NOAA
Copy link
Contributor Author

XiujuanSu-NOAA commented Sep 2, 2021 via email

@CoryMartin-NOAA
Copy link
Contributor

@XiujuanSu-NOAA much better. I will be looking forward to seeing the pull request that will add these features soon.

@XiujuanSu-NOAA
Copy link
Contributor Author

Fixed the line from: pres_idx = np.where((self.press > level_list[i]) & (
self.press < level_list[i+1]))
to
pres_idx = np.where((self.press > level_list[i]) & (
self.press <=level_list[i+1]))

from: hght_idx = np.where((self.height > level_list[i]) & (
self.height < level_list[i+1]))
to:
hght_idx = np.where((self.height >= level_list[i]) & (
self.height < level_list[i+1]))

in diags.py

@CoryMartin-NOAA
Copy link
Contributor

@XiujuanSu-NOAA great, open a new pull request with these changes whenever you are ready

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants