Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feature to return dataframe rather than numpy array #75

Open
kevindougherty-noaa opened this issue Sep 29, 2021 · 2 comments
Open
Assignees

Comments

@kevindougherty-noaa
Copy link
Collaborator

kevindougherty-noaa commented Sep 29, 2021

In get data, add an input as return_df as a boolean. If True, return the dataframe.

@aerorahul
Copy link
Contributor

Is there a reason, not to always return a dataframe?
What is the advantage of returning just the variables?

@kevindougherty-noaa
Copy link
Collaborator Author

@aerorahul You bring up a good question. I think the original idea when creating this interface was to be made for those not familiar with python. That way, all you need is two lines to get an array of a specific variable that you want (i.e. omf, oma, observation, hofx). Returning just the dataframe would remove a lot of lines from diags.py. It may require some changes in other scripts, but I am indifferent about keeping the current way or changing to just return the dataframe. What do you think? A decision should be made before I start diving in with developing regional DA monitoring scripts any further.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants