Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace real typing for binary masks #1245

Open
rem1776 opened this issue Jun 5, 2023 · 0 comments
Open

replace real typing for binary masks #1245

rem1776 opened this issue Jun 5, 2023 · 0 comments
Labels
enhancement Issue/PR for a modification that increases performance, improves syntax, or adds functionality.

Comments

@rem1776
Copy link
Contributor

rem1776 commented Jun 5, 2023

Is your feature request related to a problem? Please describe.
Real typing is used for what are essentially binary masks (must be between 0.0 or 1.0, checked via > 0.5) in horiz_interp and mosaic. Not sure if theres more cases but these should be replaced when possible to save memory and performance. It gets used in stats (horiz_interp_type.F90) , and also used in mosaic/create_xgrid.c.

Describe the solution you'd like
replace the real masks with logicals

Describe alternatives you've considered
leave as is

Additional context
wanted to change this as part of mixed mode, but these masks are arguments to interfaces so should be done separately.
@rem1776 rem1776 added the enhancement Issue/PR for a modification that increases performance, improves syntax, or adds functionality. label Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Issue/PR for a modification that increases performance, improves syntax, or adds functionality.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rem1776