Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DSOA related methods in ZoneHVACIdealAirLoadsAirSystem to conform to API #3100

Open
4 tasks
jmarrec opened this issue Apr 17, 2018 · 0 comments
Open
4 tasks

Comments

@jmarrec
Copy link
Collaborator

jmarrec commented Apr 17, 2018

The ZoneHVACIdealAirLoadsAirSystem does not conform to other ModelObject API and is currently an odd duck.

Todo:

  • Remove IDD Field for Design Specifcation Outdoor Air Object: this should be infered from the classic inheritance schema (zone -> spaces() -> spaceType)
  • Remove ZoneHVACIdealLoadsAirSystem::setDesignSpecificationOutdoorAirObject
  • Rename ZoneHVACIdealLoadsAirSystem::designSpecificationOutdoorAirObject to designSpecificationOutdoorAir to match other objects API (such as Space/SpaceType)
  • Modify implementation of ZoneHVACIdealLoadsAirSystem::designSpecificationOutdoorAir to find the appropriate Optional DSOA based on thermalZone->spaces()->designSpecificationOutdoorAir, like it's currently done in the Forward Translator: ForwardTranslateZoneHVACIdealLoadsAirSystem.cpp#L178:L198

Found while answering on unmethours here: https://unmethours.com/question/30924/outside-air-ideal-loads/

@tanushree04 tanushree04 added the Triage Issue needs to be assessed and labeled, further information on reported might be needed label Jul 21, 2020
@jmarrec jmarrec added component - Model severity - Minor Bug and removed Triage Issue needs to be assessed and labeled, further information on reported might be needed labels Feb 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants