You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There's a lot of back and forth conversions unnecessarily happening because the attributes are std::string but it should be double (or boost::optional<double> rather). We should limit the number of times we do std::stod conversions. Relates #3700 .
jmarrec
changed the title
revamp EpwDataPoint to use double attributes when appropriate
revamp EpwDataPoint to use double attributes where appropriate
Oct 1, 2019
While there's always room for improvement, using strings for storage was chosen to avoid the (inevitable) loss of precision inherent in string-to-double-to-string conversions, which is why this part of the EPW was added in the first place. Undoing that would be a step backward.
tanushree04
added
the
Triage
Issue needs to be assessed and labeled, further information on reported might be needed
label
Jul 21, 2020
tijcolem
removed
the
Triage
Issue needs to be assessed and labeled, further information on reported might be needed
label
Nov 19, 2021
There's a lot of back and forth conversions unnecessarily happening because the attributes are std::string but it should be double (or
boost::optional<double>
rather). We should limit the number of times we do std::stod conversions. Relates #3700 .eg
hpp
std::string m_extraterrestrialDirectNormalRadiation; //units Wh/m2, missing 9999., minimum 0
cpp
The text was updated successfully, but these errors were encountered: