Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forward Translator Generated WindowShadingControl object References Windows from Multiple Zones #4250

Open
TiejunWu opened this issue Mar 19, 2021 · 1 comment

Comments

@TiejunWu
Copy link

Issue overview

The code here in ForwardTranslator states its purpose being "ensure shading controls only reference windows in a single zone and determine control sequence number". Looks from the translator result, it's not doing what is expected.

Current Behavior

Currently in the resulted EnergyPlus IDF, I see that the Forward Translator does generated a "WindowShadingControl" object for each zone, but there is one "windowShaidngControl" that references many windows that belong several difference zones, and then the rest "windowShadingControl" only reference one window in it's corresponding zone.
image

Expected Behavior

I am expecting that the "windowShadingControl" object for each zone to only reference windows in that specific zone. The expected behavior for the example above should look like this:
image

Steps to Reproduce

To reproduce the IDF file, just run this OpenStudio model through the forward translator to generate the EnergyPlus IDF file.

Possible Solution

Details

Environment

Some additional details about your environment for this issue (if relevant):

  • Platform (Operating system, version): Windows 10 64 bit
  • Version of OpenStudio (if using an intermediate build, include SHA): OpenStudio 3.0.1 (+09b7c8a554)

Context

I ran the ForwardTranslator generated IDF file through EnergyPlus simulation, EnergyPlus did not report an error. I also ran the expected IDF through EnergyPlus. The simulation results from these two IDF files had negligible differences. But given that EnergyPlus requires a zone name and windows in the same zone to be referenced in the same "WindowShadingControl" object, I am not sure if it is a good idea to leave this issue unfixed. There may be other circumstances that the issue could cause errors or inaccuracies in results.

@TiejunWu TiejunWu added the Triage Issue needs to be assessed and labeled, further information on reported might be needed label Mar 19, 2021
@TiejunWu TiejunWu changed the title Forward Translator References Windows from Multiple Zones Forward Translator Generated WindowShadingControl object References Windows from Multiple Zones Mar 19, 2021
@tijcolem tijcolem added severity - Normal Bug component - IDF Translation and removed Triage Issue needs to be assessed and labeled, further information on reported might be needed labels Mar 19, 2021
@shorowit
Copy link
Contributor

But given that EnergyPlus requires a zone name and windows in the same zone to be referenced in the same "WindowShadingControl" object

Are you sure about that? My recollection is that EnergyPlus allows a single shading control for both of these situations:

  1. Windows in one zone that are controlled based on the state of another thermal zone (the one that the single shading control references).
  2. Windows in multiple zones that reference a single shading control whose control type (e.g., OnIfScheduleAllows) is unaffected by the shading control's thermal zone (in which case the choice of thermal zone doesn't matter).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants