You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The code here in ForwardTranslator states its purpose being "ensure shading controls only reference windows in a single zone and determine control sequence number". Looks from the translator result, it's not doing what is expected.
Current Behavior
Currently in the resulted EnergyPlus IDF, I see that the Forward Translator does generated a "WindowShadingControl" object for each zone, but there is one "windowShaidngControl" that references many windows that belong several difference zones, and then the rest "windowShadingControl" only reference one window in it's corresponding zone.
Expected Behavior
I am expecting that the "windowShadingControl" object for each zone to only reference windows in that specific zone. The expected behavior for the example above should look like this:
Steps to Reproduce
To reproduce the IDF file, just run this OpenStudio model through the forward translator to generate the EnergyPlus IDF file.
Possible Solution
Details
Environment
Some additional details about your environment for this issue (if relevant):
Platform (Operating system, version): Windows 10 64 bit
Version of OpenStudio (if using an intermediate build, include SHA): OpenStudio 3.0.1 (+09b7c8a554)
Context
I ran the ForwardTranslator generated IDF file through EnergyPlus simulation, EnergyPlus did not report an error. I also ran the expected IDF through EnergyPlus. The simulation results from these two IDF files had negligible differences. But given that EnergyPlus requires a zone name and windows in the same zone to be referenced in the same "WindowShadingControl" object, I am not sure if it is a good idea to leave this issue unfixed. There may be other circumstances that the issue could cause errors or inaccuracies in results.
The text was updated successfully, but these errors were encountered:
TiejunWu
added
the
Triage
Issue needs to be assessed and labeled, further information on reported might be needed
label
Mar 19, 2021
TiejunWu
changed the title
Forward Translator References Windows from Multiple Zones
Forward Translator Generated WindowShadingControl object References Windows from Multiple Zones
Mar 19, 2021
But given that EnergyPlus requires a zone name and windows in the same zone to be referenced in the same "WindowShadingControl" object
Are you sure about that? My recollection is that EnergyPlus allows a single shading control for both of these situations:
Windows in one zone that are controlled based on the state of another thermal zone (the one that the single shading control references).
Windows in multiple zones that reference a single shading control whose control type (e.g., OnIfScheduleAllows) is unaffected by the shading control's thermal zone (in which case the choice of thermal zone doesn't matter).
Issue overview
The code here in ForwardTranslator states its purpose being "ensure shading controls only reference windows in a single zone and determine control sequence number". Looks from the translator result, it's not doing what is expected.
Current Behavior
Currently in the resulted EnergyPlus IDF, I see that the Forward Translator does generated a "WindowShadingControl" object for each zone, but there is one "windowShaidngControl" that references many windows that belong several difference zones, and then the rest "windowShadingControl" only reference one window in it's corresponding zone.
Expected Behavior
I am expecting that the "windowShadingControl" object for each zone to only reference windows in that specific zone. The expected behavior for the example above should look like this:
Steps to Reproduce
To reproduce the IDF file, just run this OpenStudio model through the forward translator to generate the EnergyPlus IDF file.
Possible Solution
Details
Environment
Some additional details about your environment for this issue (if relevant):
Context
I ran the ForwardTranslator generated IDF file through EnergyPlus simulation, EnergyPlus did not report an error. I also ran the expected IDF through EnergyPlus. The simulation results from these two IDF files had negligible differences. But given that EnergyPlus requires a zone name and windows in the same zone to be referenced in the same "WindowShadingControl" object, I am not sure if it is a good idea to leave this issue unfixed. There may be other circumstances that the issue could cause errors or inaccuracies in results.
The text was updated successfully, but these errors were encountered: