Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AirTerminalDualDuctVAV: Design Specification Outdoor Air field should be replaced by Control For Outdoor Air #4388

Open
jmarrec opened this issue Aug 4, 2021 · 2 comments
Assignees
Labels
APIChange A motivated non-backward compatible change that breaks the existing API and needs to be communicated component - HVAC Enhancement Request

Comments

@jmarrec
Copy link
Collaborator

jmarrec commented Aug 4, 2021

Enhancement Request

AirTerminalDualDuctVAV has a field "Design Specification Outdoor Air" which should be replaced by "Control For Outdoor Air", and if Yes it should be populated from the Space/SpaceType.

Just like AirTerminalDualDuctVAVOutdoorAir.

Detailed Description

Current

OS:AirTerminal:DualDuct:VAV,
  [...]
  A7 , \field Design Specification Outdoor Air Object
       \type object-list
       \object-list DesignSpecificationOutdoorAirNames
       \note When the name of a DesignSpecification:OutdoorAir object is entered, the terminal
       \note unit will increase flow as needed to meet this outdoor air requirement.
       \note If Outdoor Air Flow per Person is non-zero, then the outdoor air requirement will
       \note be computed based on the current number of occupants in the zone.
       \note At no time will the supply air flow rate exceed the value for Maximum Air Flow Rate.
       \note If this field is blank, then the terminal unit will not be controlled for outdoor air flow.

Possible Implementation

Replace with:

OS:AirTerminal:DualDuct:VAV,
  [...]
  A7 , \field Control For Outdoor Air
       \note This field replaces the E+ field Design Specification Outdoor Air Object Name
       \note Refer to OpenStudio API for details
       \type choice
       \key Yes
       \key No
       \required-field
       \note If Yes and the DSOA Outdoor Air Flow per Person is non-zero, then the outdoor air requirement will
       \note be computed based on the current number of occupants in the zone.
       \note At no time will the supply air flow rate exceed the value for Maximum Air Flow Rate.
       \note If this field is No, then the terminal unit will not be controlled for outdoor air flow.

This change requires breaking API.

@jmarrec jmarrec added Enhancement Request component - HVAC APIChange A motivated non-backward compatible change that breaks the existing API and needs to be communicated labels Aug 4, 2021
@tijcolem
Copy link
Collaborator

@jmarrec Assuming this is something you would like for upcoming release in 3.3.0?

@jmarrec
Copy link
Collaborator Author

jmarrec commented Aug 20, 2021

I would need to ask @kbenne , grand protector of the API, for permission before I break it (for the greater good imho)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
APIChange A motivated non-backward compatible change that breaks the existing API and needs to be communicated component - HVAC Enhancement Request
Projects
None yet
Development

No branches or pull requests

2 participants