Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernize ControllerOutdoorAir API #4416

Open
jmarrec opened this issue Aug 25, 2021 · 0 comments
Open

Modernize ControllerOutdoorAir API #4416

jmarrec opened this issue Aug 25, 2021 · 0 comments
Labels
APIChange A motivated non-backward compatible change that breaks the existing API and needs to be communicated component - Model Enhancement Request

Comments

@jmarrec
Copy link
Collaborator

jmarrec commented Aug 25, 2021

Enhancement Request

  • Most of the getters in ControllerOutdoorAir are still named "getXxxx()" inside of "xxxx()"
  • It uses optional for return types of the getters when there are defaults, and there isn't a isXXXdefaulted
  • It's missing static methods to find valid values for choice fields "EconomizerControlType" and "LockoutType" and "Minimum Limit Type" and "Heat Recovery Bypass Control Type"

Detailed description

example:

boost::optional<bool> getHighHumidityControl() const;
bool setHighHumidityControl(bool val);

  A17, \field High Humidity Control
       \note Optional field to enable modified outdoor air flow rates based on zone relative humidity.
       \note Select Yes to modify outdoor air flow rate based on a zone humidistat.
       \note Select No to disable this feature.
       \note If the field Economizer Control Type = NoEconomizer, then this option is disabled.
       \type choice
       \default No
       \key Yes
       \key No
@jmarrec jmarrec added Enhancement Request component - Model APIChange A motivated non-backward compatible change that breaks the existing API and needs to be communicated labels Aug 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
APIChange A motivated non-backward compatible change that breaks the existing API and needs to be communicated component - Model Enhancement Request
Projects
None yet
Development

No branches or pull requests

1 participant