Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Numpy deprecation warnings in soiling algorithm #445

Open
martin-springer opened this issue Dec 18, 2024 · 0 comments
Open

Numpy deprecation warnings in soiling algorithm #445

martin-springer opened this issue Dec 18, 2024 · 0 comments

Comments

@martin-springer
Copy link
Collaborator

Describe the bug
There are a few numpy deprecation warnings left in soiling_cods_test.py

Full error message and traceback
rdtools/test/soiling_cods_test.py: 9322 warnings
/home/runner/work/rdtools/rdtools/rdtools/soiling.py:2219: DeprecationWarning:

Conversion of an array with ndim > 0 to a scalar is deprecated, and will error in future. Ensure you extract a single element from your array before performing this operation. (Deprecated NumPy 1.25.)

rdtools/test/soiling_cods_test.py: 50 warnings
/home/runner/work/rdtools/rdtools/rdtools/soiling.py:1513: DeprecationWarning:

Conversion of an array with ndim > 0 to a scalar is deprecated, and will error in future. Ensure you extract a single element from your array before performing this operation. (Deprecated NumPy 1.25.)

rdtools/test/soiling_cods_test.py: 50 warnings
/home/runner/work/rdtools/rdtools/rdtools/soiling.py:1514: DeprecationWarning:

Conversion of an array with ndim > 0 to a scalar is deprecated, and will error in future. Ensure you extract a single element from your array before performing this operation. (Deprecated NumPy 1.25.)

To Reproduce
Run tests.

Expected behavior
No deprecation warnings.

Additional context
Those warnings should be addressed with the Soiling PR #435.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant