Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[doc] [typo] The performance improvement of sequence packing is claimed to be as higher as 10x. Is it a typo? #11817

Open
shifangx opened this issue Jan 10, 2025 · 0 comments
Labels
bug Something isn't working

Comments

@shifangx
Copy link

Sequence packing is a very useful feature.
There are two places in the document (as shown in the following) that mention the performance improvement of sequence packing, but the data differs greatly.
10x performance improvement is unthinkable. Is it a typo?

https://docs.nvidia.com/nemo-framework/user-guide/latest/nemotoolkit/features/optimizations/sequence_packing.html

Image

https://docs.nvidia.com/nemo-framework/user-guide/latest/nemotoolkit/multimodal/mllm/sequence_packing.html

Image

@shifangx shifangx added the bug Something isn't working label Jan 10, 2025
@shifangx shifangx changed the title in doc, performance improvement of sequence packing is claimed to be as higher as 10x, Is it a typo? In doc, performance improvement of sequence packing is claimed to be as higher as 10x. Is it a typo? Jan 10, 2025
@shifangx shifangx changed the title In doc, performance improvement of sequence packing is claimed to be as higher as 10x. Is it a typo? [doc] [typo] The performance improvement of sequence packing is claimed to be as higher as 10x. Is it a typo? Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant