Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eth_getTransactionReceipt missing receipts - fix verification #6560

Closed
MarekM25 opened this issue Jan 18, 2024 · 5 comments · Fixed by #8027
Closed

eth_getTransactionReceipt missing receipts - fix verification #6560

MarekM25 opened this issue Jan 18, 2024 · 5 comments · Fixed by #8027

Comments

@MarekM25
Copy link
Contributor

#6344 we have a potential fix, but we haven't verified correctly if the fix is working. We should add test cases to our QA pipelines for similar issues

@kamilchodola
Copy link
Contributor

@brbrr Can you explore that topic?

If needed we can discuss that one on a call.

@kamilchodola
Copy link
Contributor

@brbrr tests cases were added for that - can you confirm no missing receipts were found?

Is the verification of ALL receipt long? If not I could add it as a test for all nodes which are syncing with NonValidator=false - let me know

@brbrr
Copy link
Contributor

brbrr commented Dec 23, 2024

I recently ran the receipt verification until Genesis on the Gnosis chain with no issues. I'll rerun it for the mainnet to be sure.

to run all the blocks from head to genesis, it takes ~20+ hours.

@quickchase
Copy link

quickchase commented Dec 29, 2024

Not sure if related, but all of our nodes (Full and Archive) on v1.27.1 and v1.30.1 cannot return this receipt:
https://gnosisscan.io/tx/0x9636356e5344ba2dfd2007cb126c661eb47a273799e897a1b3c99f4f96922fb2

We can get it via eth_getBlockReceipts but not eth_getTransactionReceipt

It seems likely related to re-orgs as there was a reorg:
https://gnosisscan.io/block/37758882/f

But this transaction is canonical

@kamilchodola
Copy link
Contributor

On archive node for this transaction:
https://gnosisscan.io/tx/0x9636356e5344ba2dfd2007cb126c661eb47a273799e897a1b3c99f4f96922fb2

we get this result:

{"method":"eth_getTransactionReceipt","params":["0x9636356e5344ba2dfd2007cb126c661eb47a273799e897a1b3c99f4f96922fb2"],"id":1,"jsonrpc":"2.0"}

{"jsonrpc":"2.0","result":null,"id":1}

At the same time eth_getblockreceipts properly returns all receipts including one for this tx.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants