Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: unwrap cause from UnexpectedException #59

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat: unwrap cause from UnexpectedException #59

wants to merge 3 commits into from

Conversation

pablojhl
Copy link
Member

@pablojhl pablojhl commented Jan 9, 2025

This unwraps the failure's cause from an UnexpectedException. The main purpose of this is to simplify the error analysis

@pablojhl pablojhl requested a review from tim-hm January 9, 2025 13:44
@pablojhl pablojhl linked an issue Jan 9, 2025 that may be closed by this pull request
Client-ts: Unwrap the cause of the errors #58
Open
tim-hm
tim-hm approved these changes Jan 10, 2025
View reviewed changes
Copy link
Collaborator

@tim-hm tim-hm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm swamped with other priority tasks at the moment so apologies I haven't been able to actually run this! But given a hasty review it looks good to me.

client-vms/package.json Outdated Show resolved Hide resolved
client-vms/tests/client.test.ts Show resolved Hide resolved
@pablojhl pablojhl force-pushed the feat/unwrap-unexpected-error branch from 8fec9c9 to b7a15fb Compare January 10, 2025 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tim-hm tim-hm tim-hm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Client-ts: Unwrap the cause of the errors
2 participants
@pablojhl @tim-hm