Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split scheduling goals and results to enable RAII use instead of error-prone manual release #12172

Open
roberth opened this issue Jan 10, 2025 · 1 comment

Comments

@roberth
Copy link
Member

roberth commented Jan 10, 2025

Generally we count on RAII to release the locks. Unfortunately for top-level goals (and maybe some other cases), the goal object may not be destroyed in a timely manner. Ideally we would split goals and goal results so we don't need to keep goals alive until their result is needed, but that would require some big changes.

Originally posted by @edolstra in #12160 (comment)

@edolstra
Copy link
Member

A lot of this will go away with #11927, since then stuff like RAII locks wouldn't need to be stored in the Goal object anymore but would be local variables.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants