Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AppImage release archives use commit hash instead of the release tag #722

Open
j4reporting opened this issue Aug 16, 2024 · 4 comments
Open
Assignees
Labels

Comments

@j4reporting
Copy link
Contributor

the Linux appImages release archives use the commit hash instead the release tag in the directory name

$ tar tvf vkquake-1.31.1_linux64.tar.gz
drwxr-xr-x root/root         0 2024-08-02 18:45 vkquake-f09814e9_linux64/
-rwxr-xr-x root/root   2778304 2024-08-02 18:45 vkquake-f09814e9_linux64/vkquake.AppImage
-rw-r--r-- root/root     18092 2024-08-02 18:45 vkquake-f09814e9_linux64/LICENSE.txt


$ tar tvf vkquake-1.30.1_linux64.tar.gz
drwxr-xr-x root/root         0 2023-03-15 04:00 vkquake-1.30.1_linux64/
-rwxr-xr-x root/root   2720960 2023-03-15 04:00 vkquake-1.30.1_linux64/vkquake.AppImage
-rw-r--r-- root/root     18092 2023-03-15 04:00 vkquake-1.30.1_linux64/LICENSE.txt

@vsonnier
Copy link
Collaborator

vsonnier commented Aug 23, 2024

Thanks, that should be fixed.

Update : not really ?

@vsonnier vsonnier reopened this Aug 23, 2024
vsonnier added a commit that referenced this issue Aug 23, 2024
@vsonnier
Copy link
Collaborator

vsonnier commented Aug 23, 2024

OK still not good. I'll let more competent people try their turn.

Introduced by e8cf9ed ?

@j4reporting
Copy link
Contributor Author

I don´t see where build-appimage.sh would run. It looks like this could be part of an extra release build process and should run when a new tag was created.
Here VERSION is set to the version string extracted from quakedef.h or now quakever.h and then it starts the normal

The push/merge linux ci process uses run-in-docker.sh with VERSION set to the commit hash, and that should remain as it is.

The latest release is identical to the CI process for the new tag and renamed to vkquake_1.31.1_linux.tar.gz. This will not change the name of archived directory.

@j4reporting
Copy link
Contributor Author

j4reporting commented Aug 25, 2024

It could have been a temporary release branch with a modified docker statement to build the image with build-appimage.sh instead of run-in-docker.sh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants