Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store "Integer strings" as Integers #5

Open
helje5 opened this issue Apr 12, 2018 · 0 comments
Open

Store "Integer strings" as Integers #5

helje5 opened this issue Apr 12, 2018 · 0 comments

Comments

@helje5
Copy link
Member

helje5 commented Apr 12, 2018

The current implementation stores "integer strings" as ByteBuffers. A key is turned into an "integer string" when the INCR, DECR family of commands are used.

SET counter 22
INCRBY counter 20

This is currently slower than necessary, we parse the ByteBuffer's into Integers, do the op, and persist as ByteBuffers again.

The RedisValue enum is prepared for that. It isn't a hard change, but will affect many places.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant