Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicated functionality #502

Open
etobella opened this issue Nov 4, 2024 · 3 comments
Open

Duplicated functionality #502

etobella opened this issue Nov 4, 2024 · 3 comments
Labels

Comments

@etobella
Copy link
Member

etobella commented Nov 4, 2024

I found that there are 2 modules in the repository that provide the same functionality:

document_page_access_group: Since v14.0. Done by @manuelregidor @sygel-technology
document_page_group: Since v11.0 Done by @etobella @dixmit

We should need to merge them on a single one. I don't care if we take document_page_access_group because it has some extra functionalities.

My proposal, would be to do the merge on v18 and keep all the authors

@etobella etobella added the bug label Nov 4, 2024
@pedrobaeza
Copy link
Member

cc @victoralmau

@victoralmau
Copy link
Member

I understand the confusion with both module and personally I think they should be merged in v18 in 1 or even in document_page (with different options at configuration level).

I think it is interesting to clarify how each module works.

document_page_group
"Visible to” is set (direct_group_ids) which allows to select groups (sales user for example). The group_ids field is also set with a compute.

A user will have access to a page if he/she does NOT have any group set and/or is part of one of them.

document_page_access_group
"Groups” (groups_id) and "Users" (user_ids) are set, neither of them is compute.
It is possible to set either Groups or Users (not both) on a page.

Several permissions are created:

  • Document Page Access: The user will be able to view pages that do not have “Groups” and “Users” or if the user is one of the indicated or if the user is part of one of the indicated groups.
  • Document Page Full Access: Has access to all pages.

@manuelregidor
Copy link
Contributor

@ValentinVinagre What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants