Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GQA Attention #59

Merged
merged 4 commits into from
Jan 11, 2024
Merged

GQA Attention #59

merged 4 commits into from
Jan 11, 2024

Conversation

RishikeshMagar
Copy link
Contributor

@RishikeshMagar RishikeshMagar commented Oct 9, 2023

Implemented GQA attention with the tests. Discussed with buttercutter and Leo Chen on Discord

Issue: #52

Copy link
Collaborator

@pascalnotin pascalnotin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @RishikeshMagar -- looks good to me! One suggestion before we merge in main: we should add a parameter to the config file that allows to select the type of attention we want in the APT instance (standard vs grouped-query) and adapt the forward method of the APTAttention class accordingly.

@RishikeshMagar
Copy link
Contributor Author

Hey @pascalnotin,
Sorry about the delay in response. I know the project has gone through a reboot and I have been following the progress discord.

I have made the changes and it is on my fork but I am not entirely sure how the requested changes work, do I submit a new PR or just keep the same one.

Copy link
Collaborator

@pascalnotin pascalnotin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the change @RishikeshMagar, and apologies for the delayed review! Ok to now merge this PR into main.

@pascalnotin pascalnotin merged commit 0d4cba5 into OpenBioML:main Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants