-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: training #66
fix: training #66
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me too -- thank you very much @othertea!
Hey @othertea. I'm running into issues when do_curriculum_learning is true. Can you let me know if you can reproduce an error when do_curriculum_learning is true in the config file? |
Hi @talkhanz , |
makes sense. Thankyou @othertea! |
After the recently merged PRs, training with usual configs no longer worked. (I'm not sure how others have been running training scripts; I did not see any new training configs.)
This PR makes minimal changes so that we can once again train with the two provided configs:
protein_lm/configs/train/toy_localcsv.yaml
,protein_lm/configs/train/toy_hf.yaml
.