Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update test case Dockerfile #304

Open
cherylking opened this issue Oct 30, 2023 · 1 comment · May be fixed by #468
Open

Update test case Dockerfile #304

cherylking opened this issue Oct 30, 2023 · 1 comment · May be fixed by #468
Assignees
@gilbysunil14
Labels
automated tests enhancement New feature or request
Milestone
CI/CD Next

Comments

@cherylking
Copy link
Member

Investigate whether the Dockerfile used in the test cases can be updated to run with a non-root user. They do a chown 1001 for some files, but do not switch to that user at the end of the file.

Affected files:

This was identified in the static app scan.
@TrevCraw TrevCraw added automated tests enhancement New feature or request labels Oct 30, 2024
@TrevCraw TrevCraw added this to the CI/CD Next milestone Oct 30, 2024
@TrevCraw TrevCraw moved this from New Issues to Prioritized in Open Liberty Developer Experience Oct 30, 2024
@gilbysunil14 gilbysunil14 self-assigned this Jan 13, 2025
@gilbysunil14
Copy link

gilbysunil14 commented Jan 13, 2025 •
edited
Loading

We can remove the --chown flag from the command. This will still work because the Dockerfile specifies the user as 1001, which is the default user in the image. The ownership of the copied files will be set to this user, so there will be no need to use the --chown flag.
In effect test cases can be run with a non-root user.

Removed the flag and raised a PR.

@aparnamichael aparnamichael moved this from Prioritized to In Progress in Open Liberty Developer Experience Jan 13, 2025
@gilbysunil14 gilbysunil14 linked a pull request Jan 14, 2025 that will close this issue
Open
@gilbysunil14 gilbysunil14 moved this from In Progress to In Review in Open Liberty Developer Experience Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gilbysunil14 gilbysunil14

Labels
automated tests enhancement New feature or request
Projects
Open Liberty Developer Experience
Status: In Review
Milestone
CI/CD Next
Development

Successfully merging a pull request may close this issue.

Dockerfile remove 'chown' to run with a non-root user gilbysunil14/liberty-tools-vscode
3 participants
@TrevCraw @cherylking @gilbysunil14