Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No config.json saved when training VAE #559

Open
txytju opened this issue Dec 15, 2024 · 1 comment
Open

No config.json saved when training VAE #559

txytju opened this issue Dec 15, 2024 · 1 comment

Comments

@txytju
Copy link

txytju commented Dec 15, 2024

https://github.com/PKU-YuanGroup/Open-Sora-Plan/blob/main/opensora/models/causalvideovae/model/modeling_videobase.py#L47 requires a config.json file in weight dir, however, when traning VAE, only .ckpt file will be saved, no config.json file saved. How to save config.json to weight dir?

@qqingzheng
Copy link
Contributor

qqingzheng commented Dec 27, 2024

if global_rank == 0:
        logger.warning("Connecting to WANDB...")
        model.save_config(ckpt_dir) # <--- this will save config.json to ckpt dir.

Sorry for late response, you can modify train_ddp.py to save config.json.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants