Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Z speed limit in Trajectory constraints depends on the position of the origin rather than only on the triplet itself #24223

Open
Luka-Filipovic opened this issue Jan 16, 2025 · 1 comment · May be fixed by #24227

Comments

@Luka-Filipovic
Copy link

Luka-Filipovic commented Jan 16, 2025

Describe the bug

The problem is described here: #23971 (comment)_

I had to implement a similar feature on an older code base (PX4 version v1.11), so I tried retrofitting this logic as it seemed handy. Initially, it appeared to work well, but after further testing, I noticed that the trajectory sometimes produced excessively large setpoints in Vz, causing it to overshoot the mission path.

Upon closer inspection, I found that the problem is related to the origin's position, which can be unpredictable and dangerous if path needs to be tracked strictly.

To Reproduce

No response

Expected behavior

No response

Screenshot / Media

Image

This should show how the origin placement can change the outcome for the same triplet

Flight Log

No response

Software Version

No response

Flight controller

No response

Vehicle type

Multicopter

How are the different components wired up (including port information)

No response

Additional context

No response

@Luka-Filipovic Luka-Filipovic changed the title [Bug] Z speed limit in Trajectory constraints depends on the position of the origin rather than the triplet itself [Bug] Z speed limit in Trajectory constraints depends on the position of the origin rather than only on the triplet itself Jan 17, 2025
@bresch
Copy link
Member

bresch commented Jan 17, 2025

Thanks for reporting this, I'll propose a fix ASAP

@bresch bresch linked a pull request Jan 17, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants