-
-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add EFFECT_TYPE_TARGET #121
Comments
Looking at the cards changed in those commits, most of them are handled by our PersistentProcedure. Does doing these changes imply removing that procedure from the cards? I'm not really used to the rulings involved here that led to the creation of that procedure or the addition of EFFECT_TYPE_TARGET to the core. I am adding 1 example of what it will look like when the change is done here https://github.com/kevinlul/edopro-script/commit/7edd30d603f351b450f3a96b93f5f067847ec901 and will wait for confirmation to decide if i apply it or not to the other cards. |
If the current form of the Persistent Proc is no longer applicable, I think the proc should be updated instead of obsoleted. The change in Shattered Axe looks like something that will be pretty similar between most cards |
Fluorohydride/ygopro-scripts#1194
Fluorohydride/ygopro-core#224
The text was updated successfully, but these errors were encountered: