Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EFFECT_TYPE_TARGET #121

Open
kevinlul opened this issue Jan 26, 2020 · 2 comments
Open

Add EFFECT_TYPE_TARGET #121

kevinlul opened this issue Jan 26, 2020 · 2 comments

Comments

@kevinlul
Copy link
Contributor

Fluorohydride/ygopro-scripts#1194

Fluorohydride/ygopro-core#224

@kevinlul kevinlul added the help wanted Mechanical changes to lots of scripts for better code quality label Jan 26, 2020
@NaimSantos
Copy link
Contributor

NaimSantos commented Jan 27, 2020

Looking at the cards changed in those commits, most of them are handled by our PersistentProcedure. Does doing these changes imply removing that procedure from the cards? I'm not really used to the rulings involved here that led to the creation of that procedure or the addition of EFFECT_TYPE_TARGET to the core. I am adding 1 example of what it will look like when the change is done here https://github.com/kevinlul/edopro-script/commit/7edd30d603f351b450f3a96b93f5f067847ec901 and will wait for confirmation to decide if i apply it or not to the other cards.

@AlphaKretin
Copy link
Contributor

If the current form of the Persistent Proc is no longer applicable, I think the proc should be updated instead of obsoleted. The change in Shattered Axe looks like something that will be pretty similar between most cards

@NaimSantos NaimSantos added has-branch Discuss in PR if open or use the same branch to make progress question Further information is requested and removed has-branch Discuss in PR if open or use the same branch to make progress labels Jan 29, 2020
@kevinlul kevinlul added the has-branch Discuss in PR if open or use the same branch to make progress label Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants