Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Dependencies Branch - Invalid hook call... #43

Closed
ewlarson opened this issue Dec 18, 2019 · 4 comments
Closed

Update Dependencies Branch - Invalid hook call... #43

ewlarson opened this issue Dec 18, 2019 · 4 comments

Comments

@ewlarson
Copy link

I'm working to add the M3 mirador-dl-plugin to the B1G Geoportal. I'm running into some issues with the plugin that are beyond me.

I'm running: mirador@^3.0.0-beta.0 and a local build of the update-dependencies branch, because it appears to be the near future of this plugin.

Here's my WIP feature branch

Alone, the new Mirador beta runs well within my GeoBlacklight instance. When I add the download plugin branch webpack compiles correctly, but when you load a page with mirador in it you see: "Invalid hook call..." ... "... error occurred in the <WithStyles(MiradorDownloadDialog)> component".

Screen Shot 2019-12-18 at 12 18 02 PM

Maybe this is related to react-iframe-comm being generally unsupported and adding "Mismatching Versions of React and React DOM"...
https://reactjs.org/warnings/invalid-hook-call-warning.html
ProjectMirador/mirador#2863
pbojinov/react-iframe-comm#14

Screen Shot 2019-12-18 at 12 46 50 PM

I'm hoping someone else has encountered this before. If anyone has any advice on how to circumvent this issue, I'd greatly appreciate it.

@mejackreed
Copy link
Contributor

I think this might be how you are importing Mirador. If you are importing the es modules version and the umd versions this error can be raised. Do you have. a branch you could share?

@mejackreed
Copy link
Contributor

ALso I think we need to 🚢 this and a new version to work with the beta.0 release #42

@ewlarson
Copy link
Author

@ewlarson
Copy link
Author

Error was resolved long ago.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants