Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Drawing a triangle using Shape.Polygon doesn't seem to work brilliantly #536

Closed
davesmith00000 opened this issue Jun 5, 2023 · 3 comments
Labels
bug Something isn't working

Comments

@davesmith00000
Copy link
Member

davesmith00000 commented Jun 5, 2023

image

Points to mull over:

  • We can't currently specify whether the Polygon is open or closed and there are no docs to say which it is.
  • There's a weird line at the top, I wonder if that line has always been there and I just haven't noticed before (based on my limited test cases)?
  • Is it worth adding a Shape.Triangle for more accurate drawing support?
@davesmith00000 davesmith00000 added the bug Something isn't working label Jun 5, 2023
@davesmith00000 davesmith00000 changed the title BUG: Drawing a triangle using Shape.Polygon does seem to work brilliantly BUG: Drawing a triangle using Shape.Polygon doesn't seem to work brilliantly Jun 18, 2023
@JPonte
Copy link
Contributor

JPonte commented Dec 11, 2023

I have the same issue and it's not just triangles.
I'm drawing some prallelograms and it works perfectly on indigo 0.14.0 but that line started appearing when I updated to 0.15.0.

@davesmith00000
Copy link
Member Author

Ah! That's a good clue though! Indigo 0.14.0 still used the old GLSL shaders, seems likely that I've just messed up the port of the polygon shader from GLSL to Scala. Thanks! 🙏

@davesmith00000
Copy link
Member Author

Fixed by @JPonte 🚀
#654

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants