SAT-SMART Driver fails to properly identify enclosure names for Realtek RTL9210 and other devices

[Kwonsunuk]

Description:
The SAT-SMART driver currently does not properly identify the enclosure names for certain devices, including those using the Realtek RTL9210 chipset and other similar configurations. These enclosures are marked as Unknown under Enclosure Name, even though they are SATSMARTCapable.

UX980 PRO:

      Product ID: 0x9210
      Vendor ID: 0x0bda  (Realtek Semiconductor Corp.)
      Version: f0.01
      Speed: Up to 10 Gb/s
      Manufacturer: RevuAhn
      Location ID: 0x01200000 / 1
      Current Available (mA): 900
      Current Required (mA): 896
      Extra Operating Current (mA): 0
      Media:
          WD_BLACK SN770 1TB:
              Capacity: 1 TB (1,000,204,886,016 bytes)
              Removable Media: No
              BSD Name: disk4
              Logical Unit: 0
              Partition Map Type: GPT (GUID Partition Table)
              S.M.A.R.T. status: Verified
              USB Interface: 0
              Volumes:
                  EFI:
                      Capacity: 209.7 MB (209,715,200 bytes)
                      File System: MS-DOS FAT32
                      BSD Name: disk4s1
                      Content: EFI
                  disk4s2:
                      Capacity: 999.99 GB (999,994,101,760 bytes)
                      BSD Name: disk4s2
                      Content: Apple_APFS
      |   "Enclosure Name" = "Unknown 0bda:9210"
      |   "SATSMARTCapable" = Yes
      |   "KnownEnclosure" = No
      |   "PassThroughMode" = "sat12"

SHARGE DISK:

              Product ID: 0xd709
              Vendor ID: 0x2d01
              Version: f0.01
              Speed: Up to 5 Gb/s
              Manufacturer: SHARGE
              Location ID: 0x00212000 / 17
              Current Available (mA): 900
              Current Required (mA): 896
              Extra Operating Current (mA): 0
              Media:
                  WD PC SN740 SDDPTQD-1T00:
                      Capacity: 1.02 TB (1,024,209,543,168 bytes)
                      Removable Media: No
                      BSD Name: disk12
                      Logical Unit: 0
                      Partition Map Type: MBR (Master Boot Record)
                      S.M.A.R.T. status: Verified
                      USB Interface: 0
                      Volumes:
                          ShargeDisk:
                              Capacity: 1.02 TB (1,024,207,093,760 bytes)
                              Free: 522.95 GB (522,946,293,760 bytes)
                              Writable: Yes
                              File System: Case-Sensitive Journaled HFS+
                              BSD Name: disk12s1
                              Mount Point: /Volumes/ShargeDisk
                              Content: Apple_HFS
              |   "Enclosure Name" = "Unknown 2d01:d709"
              |   "SATSMARTCapable" = Yes
              |   "KnownEnclosure" = No
              |   "PassThroughMode" = "sat12"

RTL9210:

              Product ID: 0x9210
              Vendor ID: 0x0bda  (Realtek Semiconductor Corp.)
              Version: 21.62
              Speed: Up to 5 Gb/s
              Manufacturer: Realtek
              Location ID: 0x00211000 / 19
              Current Available (mA): 900
              Current Required (mA): 0
              Extra Operating Current (mA): 0
              Media:
                  PC SN740 NVMe WD 512GB:
                      Capacity: 512.11 GB (512,110,190,592 bytes)
                      Removable Media: No
                      BSD Name: disk13
                      Logical Unit: 0
                      Partition Map Type: MBR (Master Boot Record)
                      S.M.A.R.T. status: Verified
                      USB Interface: 0
                      Volumes:
                          SN740:
                              Capacity: 512.11 GB (512,107,741,184 bytes)
                              Free: 503.02 GB (503,024,189,440 bytes)
                              Writable: Yes
                              File System: ExFAT
                              BSD Name: disk13s1
                              Mount Point: /Volumes/SN740
                              Content: Windows_NTFS
              |   "Enclosure Name" = "Unknown 0bda:9210"
              |   "SATSMARTCapable" = Yes
              |   "KnownEnclosure" = No
              |   "PassThroughMode" = "sat12"

Can you add the above three enclosures to the SAT-SMART driver?
Thank you.

[RJVB]

On Tuesday January 07 2025 11:48:14 권순욱 wrote: Can you add the above three enclosures to the SAT-SMART driver? Thank you.

A priori yes, but in my experience it's a bit hit and miss when I add devices; sometimes the driver doesn't work anymore at all afterwards. If you tested this and can provide a patch that's known to work I'll test it and include it if it works for me too.

[Kwonsunuk]

Hi RJVB,

Thank you for your response. I understand the potential risks of adding new devices to the SAT-SMART driver. To ensure smooth integration, I will test the driver with the proposed enclosures and provide a patch if everything works as expected.

Please let me know if there are any specific guidelines or testing procedures you'd like me to follow when preparing the patch. I'll make sure to include all relevant logs and documentation to streamline the review process.

Looking forward to collaborating on this!

[RJVB]

On Tuesday January 07 2025 20:54:12 권순욱 wrote: Thank you!

Please let me know if there are any specific guidelines or testing procedures you'd like me to follow when preparing the patch. I'll make sure to include all relevant logs and documentation to streamline the review process.

You probably understood that I am not the original developer of this kext; I cannot remember exactly why I forked the source but it must have been when I was still running OS X 10.6! I'm still hanging on to OS X 10.9 at the moment but even there quite a few things have changed in how kexts are handled. For instance, I'm never perfectly certain if adding support for (recognition of) new devices requires changing only a plist or also of the actual source code. To answer your question: please just document your understanding of why you had to make the changes you did, and what you did to test it. I think I've already manage to break the kext enough that none of my external devices was still recognised - but I probably don't need to ask you to check for that kind regression :) R.