Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue]: Compiler errors introduced with rccl-tests commit 77ae744 #103

Open
ryanhankins opened this issue Jan 22, 2025 · 0 comments
Open

Comments

@ryanhankins
Copy link

Problem Description

Compiler errors introduced with rccl-tests commit: 77ae744 in all_reduce.cu. ncclFp8E4M3 and ncclFp8E5M2 are undeclared identifiers in RCCL 6.0.0.

Operating System

SUSE Linux Enterprise Server 15 SP5

CPU

NA

GPU

NA

ROCm Version

ROCm 6.0.0

ROCm Component

No response

Steps to Reproduce

I am building RCCL tests against ROCm 6.0 as follows:

git clone https://github.com/ROCmSoftwarePlatform/aws-ofi-rccl
./configure --with-libfabric=/opt/cray --with-hip=/opt/rocm-6.0.0 --with-mpi=/opt/cray/pe/mpich/8.1.29/ofi/cray/17.0
make

(Optional for Linux users) Output of /opt/rocm/bin/rocminfo --support

I get the following compiler errors when I do:

/scratch/jenkins/cassini/rccl_new/rccl-tests/build/hipify/all_reduce.cu.cpp:68:15: error: use of undeclared identifier 'ncclFp8E4M3'
  if((type == ncclFp8E4M3 || type == ncclFp8E5M2) && op == ncclProd)
              ^
/scratch/jenkins/cassini/rccl_new/rccl-tests/build/hipify/all_reduce.cu.cpp:68:38: error: use of undeclared identifier 'ncclFp8E5M2'
  if((type == ncclFp8E4M3 || type == ncclFp8E5M2) && op == ncclProd)
                                     ^
/scratch/jenkins/cassini/rccl_new/rccl-tests/build/hipify/all_reduce.cu.cpp:93:16: error: use of undeclared identifier 'ncclFp8E4M3'
      if((i == ncclFp8E4M3 || i == ncclFp8E5M2) && j == ncclProd)
               ^
/scratch/jenkins/cassini/rccl_new/rccl-tests/build/hipify/all_reduce.cu.cpp:93:36: error: use of undeclared identifier 'ncclFp8E5M2'
      if((i == ncclFp8E4M3 || i == ncclFp8E5M2) && j == ncclProd)

This appears to be introduced with this commit:

77ae744

I was able to build by backing up to the commit immediately prior to that one.

Additional Information

No response

@ryanhankins ryanhankins changed the title [Issue]: [Issue]: Compiler errors introduced with rccl-tests commit 77ae744 Jan 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant