fix(ecau): fix seed parameters not iterable error #784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It nags about this on every build
When ECAU is injected in the content context in Firefox, it uses the `URLSearchParams` from the page context via an x-ray. However, a bug in Firefox [1] prevents us from iterating through the result of the `entries()` call. Instead, we can iterate through the `URLSearchParams` directly. [1] https://bugzilla.mozilla.org/show_bug.cgi?id=1023984
|
/deploy-preview |
|
This PR changes 1 built userscript(s):
|
github-actions bot
added a commit
that referenced
this pull request
Jul 27, 2024
fix(ecau): fix seed parameters not iterable error (#784)
|
🚀 Released 1 new userscript version(s):
|
github-actions bot
added a commit
that referenced
this pull request
Jul 27, 2024
fix(ecau): fix seed parameters not iterable error (#784)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When ECAU is injected in the content context in Firefox, it uses the
URLSearchParamsfrom the page context via an x-ray. However, a bug in Firefox prevents us from iterating through the result of theentries()call. Instead, we can iterate through theURLSearchParamsdirectly.Fixes #773.