Skip to content
This repository has been archived by the owner on Dec 5, 2022. It is now read-only.

Windows libs #1

Open
apavlenko opened this issue Mar 29, 2016 · 1 comment
Open

Windows libs #1

apavlenko opened this issue Mar 29, 2016 · 1 comment

Comments

@apavlenko
Copy link

  1. I suggest the following improvement to the msvc.bat
set VC2013_DIR=C:\Program Files (x86)\Microsoft Visual Studio 12.0
call "%VC2013_DIR%\VC\vcvarsall.bat" x86_amd64

also it may be renamed to msvc2013.bat
2. I suggest the following improvement in the libvlc-sdk.pri

win32 {
## Windows common build here

!contains(QMAKE_TARGET.arch, x86_64) {
    ## Windows x86 (32bit) specific build here
    LIBS += $$PWD/lib/msvc/libvlc.lib
} else {
    ## Windows x64 (64bit) specific build here
    LIBS += $$PWD/lib/msvc/libvlc.x64.lib
}
} else ...
  1. why libvlccore.lib is created but is not used?
@RSATom
Copy link
Owner

RSATom commented Mar 29, 2016

it's helper, you don't need it. Just use libvlc-sdk directly.

  1. Then it will be better use VS120COMNTOOLS environment variable there.
  2. You could make Pull Request
  3. It was intended for use in out-of-tree libvlc plugins (https://github.com/RSATom/vmem2 for example). It shouldn't be used in any other ways.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants