Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Streamlining installation using a conda environment file #10

Open
multimeric opened this issue Aug 3, 2023 · 5 comments
Open

Streamlining installation using a conda environment file #10

multimeric opened this issue Aug 3, 2023 · 5 comments

Comments

@multimeric
Copy link

multimeric commented Aug 3, 2023

Hi, I was recently trying to set up this pipeline on our HPC, and it occurred to me that we could streamline all the conda install, pip install and python setup.py install commands by exporting a conda environment definition file, so that users would only need to clone the repo, then conda env create -f=/path/to/environment.yml and everything should work.

Would you be interested in me contributing something like that?

@lhatsk
Copy link
Collaborator

lhatsk commented Aug 7, 2023

Hi,
Yes, that would great! I guess the only manual step that will remain is to copy stereo_chemical_props.txt?

Thanks!

@multimeric
Copy link
Author

Yeah so conda won't be able to handle data files like that, but I wonder if that file could be obtained within the AlphaLink2 code, either during setup or at runtime, so users don't have to manually install it?

@lhatsk
Copy link
Collaborator

lhatsk commented Aug 9, 2023

Hm, where would you include it? E.g., download/ copy at the beginning of run_alphalink.sh if it doesn't exist yet?

@multimeric
Copy link
Author

I don't know if it's subject to any license issues that prevent it, but what I would do is include it in the package as package data: https://setuptools.pypa.io/en/latest/userguide/datafiles.html. To do that all you need to do is commit it to the git repository and ensure the project metadata is configured correctly. It's only ~ 9 kilobytes so I doubt anyone would really mind.

@lhatsk
Copy link
Collaborator

lhatsk commented Sep 11, 2023

I don't know about the licensing, my guess is there is some issue, otherwise Deepmind would have also packaged it. I'll check it out. I guess just doing a quick check and downloading if necessary isn't too bad.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants